search

JulesKouatchou / basic_language_comparison

Other
86 stars 22 forks source link

Iterate through digits directly in Julia munchausen implementation #1

Closed brenhinkeller closed 4 years ago

brenhinkeller commented 5 years ago

Iterating through the digits directly using division and modulus (using code borrowed from your existing C implementation) speeds up the Julia munchausen number code by about a factor of eight

brenhinkeller commented 5 years ago

Nothing too important, but I think it illustrates a noteworthy property of Julia that the naive "just write like you would in C" approach tends to be fast

ViralBShah commented 4 years ago

Would be nice to merge this before the next round of benchmarks.

JulesKouatchou commented 4 years ago

Sorry, it is only now that I saw the pull request. Thank you for your contribution.

brenhinkeller commented 4 years ago

Thanks!

On Feb 19, 2020, at 1:45 PM, JulesKouatchou notifications@github.com wrote:

Sorry, it is only now that I saw the pull request. Thank you for your contribution.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JulesKouatchou/basic_language_comparison/pull/1?email_source=notifications&email_token=ACENNQ3HXHTM73LY42AGSR3RDV45HA5CNFSM4JLOAHV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMI7ZVQ#issuecomment-588381398, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACENNQYOOJMTU4XPEV7YOVLRDV45HANCNFSM4JLOAHVQ.

ViralBShah commented 4 years ago

Please do see the discussion in #7 too.