search

JuliaAI / CatBoost.jl

Julia wrapper of the python library CatBoost for boosted decision trees
MIT License
11 stars 3 forks source link

Switch from PyCall.jl to PythonCall.jl #15

Closed tylerjthomas9 closed 1 year ago

tylerjthomas9 commented 1 year ago

I have started working on the conversion to PythonCall.jl (#14). Let me know what you think.

codecov[bot] commented 1 year ago

Codecov Report

Merging #15 (03b08a0) into main (24ab8a6) will increase coverage by 2.61%. The diff coverage is 100.00%.

:exclamation: Current head 03b08a0 differs from pull request most recent head e661df7. Consider uploading reports for the commit e661df7 to get more accurate results

@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   90.24%   92.85%   +2.61%     
==========================================
  Files           1        1              
  Lines          41       28      -13     
==========================================
- Hits           37       26      -11     
+ Misses          4        2       -2
Impacted Files Coverage Δ
src/CatBoost.jl 92.85% <100.00%> (+2.61%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

tylerjthomas9 commented 1 year ago

I accidently tagged the wrong Eric in my commit. Sorry about that... Thank you for the suggestions. I have made all the changes.

ericphanson commented 1 year ago

Thank you! LGTM