search

JuliaAI / CatBoost.jl

Julia wrapper of the python library CatBoost for boosted decision trees
MIT License
11 stars 3 forks source link

Fix missing `to_catboost`, `to_pandas`, `feature_importance` docs. Add `Py` type to feature importance input #26

Closed tylerjthomas9 closed 1 year ago

tylerjthomas9 commented 1 year ago

to_catboost, to_pandas, feature_importance were missing docstrings (they aren't exported, so we just had to update them to have CatBoost. in front of them.

Additionally, CatBoost.feature_importance assumes that a Python object (specifically a catboost model) is being passed to it, so I added the Py type

codecov-commenter commented 1 year ago

Codecov Report

Merging #26 (1ca3e7b) into main (691e068) will increase coverage by 0.27%. The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   77.30%   77.57%   +0.27%     
==========================================
  Files           6        6              
  Lines         163      165       +2     
==========================================
+ Hits          126      128       +2     
  Misses         37       37
Impacted Files Coverage Δ
src/wrapper.jl 91.17% <100.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

tylerjthomas9 commented 1 year ago

@ericphanson No rush at all, but can you take a look at this when you get a chance? I want to push out the docs updates with the Python library version bump, so there are no longer missing docstrings in the docs.