search

JuliaAI / CatBoost.jl

Julia wrapper of the python library CatBoost for boosted decision trees
MIT License
11 stars 3 forks source link

fix deprecation warning in `pandas_to_df`, add test, mv exports #5

Closed ericphanson closed 3 years ago

ericphanson commented 3 years ago

We were doing pandas_df[c] which is deprecated syntax for getproperty(pandas_df, c) apparently. Julia on 1.5+ doesn't show deprecation warnings except during Pkg.test and our examples are kind of verbose so maybe we missed it there (or maybe we didn't hit this method).

codecov[bot] commented 3 years ago

Codecov Report

Merging #5 (29d4d18) into main (a548b0b) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage   90.24%   90.24%           
=======================================
  Files           1        1           
  Lines          41       41           
=======================================
  Hits           37       37           
  Misses          4        4
Impacted Files Coverage Δ
src/CatBoost.jl 90.24% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a548b0b...29d4d18. Read the comment docs.

ericphanson commented 3 years ago

bump @femtomc