Closed EssamWisam closed 5 months ago
Tutorial Name | Changes Introduced |
---|---|
D0-categorical | Updated manifest only |
D0-dataframe | Updated manifest only |
D0-loading | Updated manifest only |
D0-processing | Translated multiple plots |
D0-scitype | Updated manifest only |
Tutorial Name | Changes Introduced |
---|---|
ISL-lab-10 | 4 One-liners, 2 Plots |
ISL-lab-2 | 1 Plot |
ISL-lab-3 | 3 Plots Only |
ISL-lab-4 | 4 Plots, 3 One-liners |
ISL-lab-5 | 4 Plots Only |
ISL-lab-6b | 6 Plots Done |
ISL-lab-8 | 1 One-liner |
ISL-lab-9 | 1 Plot Only |
For some reason the lasso regressor in ISL-lab-6b
after the MLJ update produces zeros for all coefficients.
Tutorial Name | Changes Introduced |
---|---|
A-composing-models | One line |
A-ensembles | Fixed Plots |
A-ensembles-2 | One line, Fixed Plots |
A-ensembles-3 | Deterministic only. |
A-fit-predict | One line |
to be removed 💀 #203 | |
to be removed 💀 #203 | |
A-model-choice | Updated manifest only |
A-model-tuning | Fixed Plots |
A-stacking | Fixed multiple plots. Deterministic only |
I may not be able to commit the changes in the same order as in the table since I worked on multiple branches.
Tutorial Name | Changes Introduced |
---|---|
EX-GLM | Two one liners |
EX-airfoil | Fixed one plot. |
EX-boston-flux | Fixed one plot. |
EX-breastcancer | Fixed two plots and added two one liners (not easy) |
EX-horse | Update manifest only |
EX-housekingcounty | Fixed two plots |
EX-powergen | Fix seven plots |
EX-wine | Fix one plot |
EX-AMES | Changed one line. DeterministicComposite . |
EX-boston-lgbm | ArgumentError: NULL library handle |
EX-crabs-xgb | L1HingeLoss ; |
EX-telco | Fixed one line. ERROR: type NamedTuple has no field feature_importances |
This is a highly valuable contribution, thanks.
Thank you.
Have finished my initial review and will now investigate some of the issues you have raised.
Please ping me when you have addressed my comments and any minor changes you still want to make here.
@ablaom I have addressed them in text but will address them by revisiting the code soon.
Can we please make those Pkg.update -> Pkg.instantiate replacements?
@EssamWisam The tutorial DRAFT-EX-creditfraud was never a live tutorial, but an abandoned work-in-progress. Seems a shame not to bring it in, so I am working on a separate PR to formerly instate it.
Can we please make those Pkg.update -> Pkg.instantiate replacements?
I planned to do so after finishing with all tutorials since I actually use that line to update the manifest. Would you like me to do that earlier?
@EssamWisam The tutorial DRAFT-EX-creditfraud was never a live tutorial, but an abandoned work-in-progress. Seems a shame not to bring it in, so I am working on a separate PR to formerly instate it.
Alright. I think it's not urgent compared to having all existing tutorials updated so we can finally deploy this.
I've finished off the credit fraud tutorial: https://github.com/JuliaAI/DataScienceTutorials.jl/pull/196
@ablaom I have addressed all your comments in the commits above.
I planned to do so after finishing with all tutorials since I actually use that line to update the manifest. Would you like me to do that earlier?
No that's fine.
I'm waiting on:
so I can update the Telco tutorial.
I found that I didn't validate the credit-fraud
tutorials because it wasn't in the horizontal nav before fix-nav
was introduced. Found some minor issues and fixed.
Found that ensembles-3
required fixes to render properly after it was moved to the advanced section (e.g., correct Project.toml reference in code) so fixed that as well.
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
@ablaom Excuse me for being unprofessional in not making PRs for these changes. Point is they were deterministic and minor so I thought it's faster to get by them quickly. Don't mind any cross you see next to a commit, it implies I pushed something from __site by mistake in that commit or a previous one (which I always straightforwardly fix with a revert).
I will merge this now.
In this PR, tutorials will be updated to satisfy the following two conditions:
Plots.jl
(i.e., remove the Python dependency)To do:
Pkg.update()
wthPkg.instantiate()
in tutorials