search

JuliaAI / DataScienceTutorials.jl

A set of tutorials to show how to use Julia for data science (DataFrames, MLJ, ...)
https://juliaai.github.io/DataScienceTutorials.jl/
MIT License
116 stars 18 forks source link

New "Contribute" nav-bar item -> 404 Error #237

Closed ablaom closed 4 months ago

ablaom commented 4 months ago

It looks like the url for the github pages gets prepended to the desired path that I added (see below). Is this not the way to specify an absolute url?

https://github.com/JuliaAI/DataScienceTutorials.jl/blob/80bd90bae3b729b5982c1b284acfbef96f206727/_layout/head.html#L42

EssamWisam commented 4 months ago

I made a PR that attempts to fix that. I believe yes, it is the way but there is logic elsewhere in the site that changes this by appending Github's domain when the site is in deployment (you are viewing a client version). In particular, such logic is necessary for any internal link but not external links.

ablaom commented 4 months ago

Okay, now the nav bar completely disappeared. And the "next tutorial buttons" have not effect. Screen Shot 2024-06-25 at 8 14 50 AM

I'm going to have to revert the changes for now, as this has effectively killed the site.

EssamWisam commented 4 months ago

Oh my goodness. Sorry it was not possible to test since the logic runs if the site is hosted. I have noticed now that the function name is startsWith and not startWith as I had. No idea why no squiggly lines showed up for me.

ablaom commented 4 months ago

Okay, I'll try that, thank you.

ablaom commented 4 months ago

Sorted. Thanks for the prompt investigation @EssamWisam 🙏🏾