Closed EssamWisam closed 10 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
60b4461
) 95.22% compared to head (29d584e
) 95.22%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@ablaom This maps the old setup into one where the scitypes are correct as needed for #76.
Regarding the last commit, I noticed that a change I have done late in the development of the package to let random resampling operate on categorical types was not reflected on the scitypes used. The commit fix this. In this, I also assumed that if a matrix is AbstractMatrix{<:Real}
then it also is AbstractMatrix{Infinite}
The commit fix this. In this, I also assumed that if a matrix is AbstractMatrix{<:Real} then it also is AbstractMatrix{Infinite}
Strictly speaking this is not correct because Rational <: Real
and AbstractIrrational <: Real
but objects subtyping these have Unknown
scitype. On reflection, we could perhaps have included them in the Continuous
scitype. (We couldn't include all Real
because Integer <: Real
and Integer
is for Count
. )
On reflection, we could perhaps have included them in the
Continuous
scitype. (We couldn't include allReal
becauseInteger <: Real
andInteger
is forCount
. )
Sure, I could do that but then a matrix of integers (corresponding to a purely categorical dataset) would work perfectly with the functional interface but not the MLJ interface; meanwhile, it's quite odd to have a dataset of irrational numbers or numbers taking the rational form a//b.
What do you think?
Closes #76