Closed ablaom closed 8 months ago
Yes, the float thing is incorrect (and the fact that a matrix is accepted); it's not synced with the docstring in Imbalance.jl
. I will fix that. I will also check if there is any other type misinformation in MLJ specific docs for other methods.
Thank you bringing this up.
As a sidenote, RandomWalkOversampler
and SMOTENC
are the only two methods that don't support matrix input for MLJ (because they require categorical columns to be flagged which the MLJ interface doesn't account for). I think adding that support shouldn't be hard and makes the package more consistent.
From the doc-string for MLJ.SMOTENC:
while we have
suggesting:
X
can not be a matrix, andX
may have columns with element scitype<:Finite
(not just floats)contrary to doc-string.