JuliaAI / MLFlowClient.jl

Julia client for MLFlow.
https://juliaai.github.io/MLFlowClient.jl/
MIT License
42 stars 8 forks source link

Incorrect start time displayed on MLFlow dashboard #20

Closed yezhengkai closed 1 year ago

yezhengkai commented 2 years ago

The MLFlow REST API Create Run and Update Run documentation shows that start_time and end_time should be Unix timestamp.

And from Converting Date/Time without time zone information and https://github.com/mlflow/mlflow/issues/30#issuecomment-396094191, we know that Unix timestamp should be UTC+0.

But createrun and updaterun are using local time, causing the wrong time to be displayed on MLFlow dashboard.

https://github.com/JuliaAI/MLFlowClient.jl/blob/7c88ec42fc3c4c30690454fa8876befe4afe6bcc/src/runs.jl#L17-L24 https://github.com/JuliaAI/MLFlowClient.jl/blob/7c88ec42fc3c4c30690454fa8876befe4afe6bcc/src/runs.jl#L64-L77

pebeto commented 1 year ago

The displayed start_time in dashboard is related to the local machine timezone. We are not being able to modify that date unless we scale this issue to MLFlow. Julia has a native way to get the UTC-0 just by passing UTC as parameter in now() (like in #25).