search

JuliaAI / MLFlowClient.jl

Julia client for MLFlow.
https://juliaai.github.io/MLFlowClient.jl/
MIT License
42 stars 8 forks source link

Enable remote logging #22

Closed svilupp closed 1 year ago

svilupp commented 1 year ago

TL;DR This is a proposal to enable remote logging (eg, Databricks or internal MLFlow servers)

Closes #21

Implementation:

svilupp commented 1 year ago

The overall test suite keeps failing but that should be independent of my changes. I'll investigate it tomorrow.

svilupp commented 1 year ago

This PR is ready for review. It would be awesome if you could take a look @deyandyankov .

I've added docstrings and tests for the new method.

For visibility, the relevant tests pass but the overall test suite fails, because my computer blocks localhost (not sure how common/uncommon that is), but everything passes if I changed it to standard 127.0.0.1 (see tests fix branch)

deyandyankov commented 1 year ago

this is now merged, I've bumped the version to 0.4.0 and have submitted the new version to be registered in General. Thank you for your contribution!

deyandyankov commented 1 year ago

Thanks for the PR! I'll review this evening.

On Tue, 2 Aug 2022, 10:55 J S, @.***> wrote:

This PR is ready for review. It would be awesome if you could take a look @deyandyankov https://github.com/deyandyankov .

I've added docstrings and tests for the new method.

For visibility, the relevant tests pass but the overall test suite fails, because my computer blocks localhost (not sure how common/uncommon that is), but everything passes if I changed it to standard 127.0.0.1 (see tests fix branch https://github.com/svilupp/MLFlowClient.jl/tree/fix-test-suite)

— Reply to this email directly, view it on GitHub https://github.com/JuliaAI/MLFlowClient.jl/pull/22#issuecomment-1202273000, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWZRGYXS4HLSTJLVQPS5T3VXDWCFANCNFSM55IUHFDA . You are receiving this because you were mentioned.Message ID: @.***>