Open ablaom opened 2 years ago
@ablaom can you send me a link to where I can see all of the model documentation in its current form?
Model-specific documentation is not currently collated. Part of the GSoD project is to create and organise such a collation. So I'd have to write a script that loads every model in the registry (about 200 models) and calls @doc
on those types. But with the exception of those packages with ✔️ s above they're mostly empty or quite minimal. Do you want me to write this script? Perhaps you could say would exactly you want this for?
Regarding other documentation. We have a manual and this summary of other learning resources.
Great, the propsoal has been submitted and is available here: https://julialang.org/jsoc/gsod/2022/proposal/
After some preparation and discussion, I am announcing a new standard for MLJ model doc-strings, documented here. I believe detailed doc-strings can greatly improve the on-ramp for new MLJ users, but rolling them out across the MLJ ecosystem is a huge task. Please help if you can.
Here's the list:
OneHotEncoder
to reflect https://github.com/JuliaAI/MLJModels.jl/pull/457Assign yourself by adding your GH handle next the relevant package, or ping me below.
@jbrea @sjvollmer I understand you are using MLJ for teaching these days. Feel free to star (*) or otherwise indicate two or three priority packages (or better still, contribute a PR 😜 )
Procedure
Generally, the procedure for updating the document strings for a package looks like this:
doc_header
and the newhuman_name
trait available, unless you have no plans to reference either.metadata_model
, then remove anydescr
ordocstring
kwargs (these two are synonyms) in themetadata_model
call. If instead (and atypically) there is an explicitdocstring
trait declaration (as inMLJModelInterface.docstring(::Type{<:FunkyModel}) = "A funky model"
) then delete it.Assimilate the content of the moved doc-string into a new compliant doc-string, with the help of an existing complaint doc-string you use as a template (classifiers and regressors, transformers).
Check the docstring. If the programatically generated header reads strangely, add a
human_name
declaration (eg, in themetadata_model
call).