Ensure packages implementing Code are threadsafe

JuliaAI / MLJBase.jl

Core functionality for the MLJ machine learning framework

MIT License

160 stars 46 forks source link

Ensure packages implementing Code are threadsafe #298

Open OkonSamuel opened 4 years ago

OkonSamuel commented 4 years ago

Apart from the fact that packages need to implement MLJ's API to be used in MLJ. They also need to ensure that that their code is thread safe otherwise things break.

ablaom commented 4 years ago

I think some developers (myself included) will not too familiar with what is and what is not safe. Is there a list somewhere? (I know only this discussion)

OkonSamuel commented 4 years ago

The updated docs here can supplement that. Basically the key point is that should avoid functions with side effects (i.e mutates the global state)