search

JuliaAI / MLJDecisionTreeInterface.jl

MIT License
9 stars 4 forks source link

Incorporate feature importance #24

Closed kescobo closed 2 years ago

kescobo commented 2 years ago

From https://github.com/JuliaAI/DecisionTree.jl/pull/182

@OkonSamuel you said you were working on it? Mostly opening this issue so I can track it, I'm eager to put it to use!

kescobo commented 2 years ago

From slack, related PRs:

https://github.com/JuliaAI/MLJModelInterface.jl/pull/148 https://github.com/JuliaAI/MLJBase.jl/pull/798

ablaom commented 2 years ago

DecisionTree provides three different feature importances, so I expect we need to add a hyper-pararameter to control the active one.

ablaom commented 2 years ago

The apparatus is now in place for this to proceed. The key documentation is here:

https://github.com/JuliaAI/MLJModelInterface.jl/blob/1628202d5537e8b423fd1d542f7dfbb8e92fb051/src/model_api.jl#L169

OkonSamuel commented 2 years ago

closed by #28