search

JuliaAI / MLJLinearModels.jl

Generalized Linear Regressions Models (penalized regressions, robust regressions, ...)
MIT License
80 stars 13 forks source link

fix scale_penalty_with_samples=true for proxgrad #112

Closed jbrea closed 2 years ago

jbrea commented 2 years ago

The L1 part in the ProxGrad solver did not respect the argument scale_penalty_with_samples = true argument before this PR.

codecov-commenter commented 2 years ago

Codecov Report

Merging #112 (6d2378f) into dev (9f1987c) will increase coverage by 0.00%. The diff coverage is 100.00%.

:exclamation: Current head 6d2378f differs from pull request most recent head b293b59. Consider uploading reports for the commit b293b59 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #112   +/-   ##
=======================================
  Coverage   96.04%   96.05%           
=======================================
  Files          21       21           
  Lines         860      861    +1     
=======================================
+ Hits          826      827    +1     
  Misses         34       34
Impacted Files Coverage Δ
src/fit/proxgrad.jl 95.12% <100.00%> (ø)
src/glr/prox.jl 100.00% <100.00%> (ø)
src/loss-penalty/utils.jl 88.88% <100.00%> (+0.65%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9f1987c...b293b59. Read the comment docs.