jbrea commented 1 year ago

Sometimes I wish to have a bit more control over the Optim options, in particular to set, for example, a time limit or change the tolerance level.

If the proposed changes are welcome, I would adapt the doc strings and add some tests.

ablaom commented 1 year ago

Sounds like a good idea, thanks. If possible, we should see if @tlienart can review.

codecov-commenter commented 1 year ago

Codecov Report

Merging #133 (c6eebe5) into dev (38e2def) will decrease coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #133      +/-   ##
==========================================
- Coverage   94.64%   94.62%   -0.02%     
==========================================
  Files          20       20              
  Lines         878      875       -3     
==========================================
- Hits          831      828       -3     
  Misses         47       47

Impacted Files	Coverage Δ
src/fit/solvers.jl	`100.00% <ø> (ø)`
src/fit/newton.jl	`100.00% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ablaom commented 1 year ago

@tlienart For, now can you just say if you are happy for @jbrea to proceed with a more detailed PR?

tlienart commented 1 year ago

This makes perfect sense, thanks @jbrea ; I've also added you as a collaborator to the repo since you've now contributed a lot to it

JuliaAI / MLJLinearModels.jl

more flexible optim options #133

Codecov Report