Optim defaults doc - Githubissues

JuliaAI / MLJLinearModels.jl

Generalized Linear Regressions Models (penalized regressions, robust regressions, ...)

MIT License

80 stars 13 forks source link

Optim defaults doc #139

Closed olivierlabayle closed 1 year ago

olivierlabayle commented 1 year ago

Content of PR:

docs: An example of how to customize a solver via the MLJ API
src: Update the Optim.Options() to Optim.Options(f_tol=1e-4)
deps: I also updated the Package depdendency structure with a test/Project.toml (hope that's allright)

I haven't added any test (but happy to do so if you think of anything useful), just fixed one.

tlienart commented 1 year ago

Nice thank you. Given this changes a default parameter it will be a minor release (0.9) so you could adjust the Project.toml accordingly too. Bar that, a few general comments but I otherwise think this is a useful nice PR :+1:

olivierlabayle commented 1 year ago

I think all comments are resolved, please let me know otherwise and I can merge.

tlienart commented 1 year ago

Thanks Olivier!