search

JuliaAI / MLJLinearModels.jl

Generalized Linear Regressions Models (penalized regressions, robust regressions, ...)
MIT License
80 stars 13 forks source link

removing all global pointers #67

Closed tlienart closed 4 years ago

tlienart commented 4 years ago

cc: @OkonSamuel :)

closes #64

codecov-io commented 4 years ago

Codecov Report

Merging #67 into master will increase coverage by 1.64%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage   92.99%   94.63%   +1.64%     
==========================================
  Files          22       21       -1     
  Lines         814      802      -12     
==========================================
+ Hits          757      759       +2     
+ Misses         57       43      -14
Impacted Files Coverage Δ
src/MLJLinearModels.jl 100.00% <ø> (ø)
src/fit/default.jl 66.66% <100.00%> (-13.34%) :arrow_down:
src/glr/d_l2loss.jl 100.00% <100.00%> (ø)
src/glr/d_logistic.jl 100.00% <100.00%> (ø)
src/glr/d_robust.jl 100.00% <100.00%> (+10.85%) :arrow_up:
src/utils.jl 97.26% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d3e9994...683f7ba. Read the comment docs.

tlienart commented 4 years ago

There's ±10% performance decrease overall but it's still ok. I need to run more serious timed comparisons with sklearn / R