Closed OkonSamuel closed 4 years ago
Thanks I'll try to fix that asap
yeah that's a shortcircuit that's buggy, I think that's a recent PR that I hadn't properly tested
yeah that's a shortcircuit that's buggy, I think that's a recent PR that I hadn't properly tested
I guess the MMI.schema
method isn't extended
What code did you use that threw this bug?
MMI.schema(X)
. This threw the following error.
ERROR: MethodError: no method matching schema(::MLJModelInterface.FullInterface, ::Val{:table}, ::Tables.MatrixTable{Array{Float64,2}})
hmm that should work, do you have the latest version of MLJBase?
I just did:
julia> MLJBase.MMI.schema(Xt)
┌─────────┬─────────┬────────────────────────────┐
│ _.names │ _.types │ _.scitypes │
├─────────┼─────────┼────────────────────────────┤
│ x1 │ Float64 │ ScientificTypes.Continuous │
│ x2 │ Float64 │ ScientificTypes.Continuous │
│ x3 │ Float64 │ ScientificTypes.Continuous │
│ x4 │ Float64 │ ScientificTypes.Continuous │
│ x5 │ Float64 │ ScientificTypes.Continuous │
└─────────┴─────────┴────────────────────────────┘
_.nrows = 100
but I'm using the dev branch of MLJBase, let's see...
Edit: no with MLJBase 0.13.5
it works for me, could you check?
Okay. Let me check. Am updating to latest version
@tlienart. It works
@tlienart. I just tested the master branch of this repo with nthreads=2
on MLJ.evaluate
and MLJ.tunedmodel
. It works perfectly. No issues.
awesome thanks!
at https://github.com/alan-turing-institute/MLJLinearModels.jl/blob/master/src/mlj/interface.jl#L22 the function
schema(X)
fails. @tlienart