@tlienart Currently you expose multiclass and nclasses parameter to the user and you mutate these parameters in MMI.fit method depending on the data.
I think this violates MLJ assumption that model hyperparameters should not be mutated during fitting.
I think it's better not to expose these hyparameters in model struct (you can still set them internally though)
@tlienart Currently you expose
multiclass
andnclasses
parameter to the user and you mutate these parameters inMMI.fit
method depending on the data. I think this violates MLJ assumption that model hyperparameters should not be mutated during fitting. I think it's better not to expose these hyparameters in model struct (you can still set them internally though)