search

JuliaAI / MLJLinearModels.jl

Generalized Linear Regressions Models (penalized regressions, robust regressions, ...)
MIT License
80 stars 13 forks source link

Don't expose `multiclass` and `nclasses` #76

Closed OkonSamuel closed 4 years ago

OkonSamuel commented 4 years ago

@tlienart Currently you expose multiclass and nclasses parameter to the user and you mutate these parameters in MMI.fit method depending on the data. I think this violates MLJ assumption that model hyperparameters should not be mutated during fitting. I think it's better not to expose these hyparameters in model struct (you can still set them internally though)

OkonSamuel commented 4 years ago

@tlienart could you tag a new release. Am writing a tutorial using this package

tlienart commented 4 years ago

Oh I thought I did?

tlienart commented 4 years ago

Yeah 0.5 does this