search

JuliaAI / MLJModelInterface.jl

Lightweight package to interface with MLJ
MIT License
37 stars 8 forks source link

Address corner case for `synthesize_docstring(M)` #142

Closed ablaom closed 2 years ago

ablaom commented 2 years ago

The method fails if M() is not defined. Although the interface explicitly requires M() to be defined, it occassionally is not in tests that construct dummy models for pure testing purposes. It seems prudent to just return a simpler string in this case, rather than change those tests.

codecov-commenter commented 2 years ago

Codecov Report

Merging #142 (e59babd) into dev (8b11617) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #142   +/-   ##
=======================================
  Coverage   88.88%   88.88%           
=======================================
  Files           8        8           
  Lines         324      324           
=======================================
  Hits          288      288           
  Misses         36       36
Impacted Files Coverage Δ
src/metadata_utils.jl 100.00% <100.00%> (ø)
src/model_traits.jl 75.47% <0.00%> (-0.90%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8b11617...e59babd. Read the comment docs.