JuliaAI / MLJModelInterface.jl

Lightweight package to interface with MLJ
MIT License
37 stars 8 forks source link

Probabilisitic set #167

Closed pat-alt closed 1 year ago

pat-alt commented 1 year ago

Added the abstract type necessary to add conformal classifiers for general use (see related issue). Nothing done yet with respect to downstream tasks. Decided to use only ProbabilisticSet for now, as I'm not sure the other case is necessary. Also added the trait definition.

codecov-commenter commented 1 year ago

Codecov Report

Merging #167 (7c2e2c4) into dev (100c477) will decrease coverage by 0.21%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev     #167      +/-   ##
==========================================
- Coverage   88.70%   88.48%   -0.22%     
==========================================
  Files           8        8              
  Lines         354      356       +2     
==========================================
+ Hits          314      315       +1     
- Misses         40       41       +1     
Impacted Files Coverage Δ
src/MLJModelInterface.jl 100.00% <ø> (ø)
src/model_traits.jl 75.00% <0.00%> (-1.37%) :arrow_down:
src/metadata_utils.jl 98.38% <0.00%> (+0.02%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ablaom commented 1 year ago

@pat-alt Perhaps you missed my suggestion above?

pat-alt commented 1 year ago

@pat-alt Perhaps you missed my suggestion above?

Indeed, I completely missed that, sorry! And thanks for doing, great to see this has now been merged. Thanks!