search

JuliaAI / MLJModelInterface.jl

Lightweight package to interface with MLJ
MIT License
37 stars 8 forks source link

flat_params hotfix respect to empty models #179

Closed pebeto closed 1 year ago

pebeto commented 1 year ago

177 missed the capability to get the tuple representation from an empty struct property. This PR solves that specific problem by adding a race condition.

codecov-commenter commented 1 year ago

Codecov Report

Merging #179 (f9de574) into dev (fc6323b) will not change coverage. The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##              dev     #179   +/-   ##
=======================================
  Coverage   89.21%   89.21%           
=======================================
  Files           8        8           
  Lines         380      380           
=======================================
  Hits          339      339           
  Misses         41       41
Files Changed Coverage Δ
src/parameter_inspection.jl 100.00% <100.00%> (ø)
pebeto commented 1 year ago

By discussed with @ablaom, we can simplify the race condition approach by just doing the verification in the trait.