search

JuliaAI / MLJModelInterface.jl

Lightweight package to interface with MLJ
MIT License
37 stars 8 forks source link

Fix a corner case of flat_params #182

Closed ablaom closed 10 months ago

ablaom commented 10 months ago

Partially addresses https://github.com/JuliaAI/MLJFlow.jl/issues/22

codecov[bot] commented 10 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (ffb47b1) 89.21% compared to head (da7bb36) 89.26%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #182 +/- ## ========================================== + Coverage 89.21% 89.26% +0.05% ========================================== Files 8 8 Lines 380 382 +2 ========================================== + Hits 339 341 +2 Misses 41 41 ``` | [Files](https://app.codecov.io/gh/JuliaAI/MLJModelInterface.jl/pull/182?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaAI) | Coverage Δ | | |---|---|---| | [src/parameter\_inspection.jl](https://app.codecov.io/gh/JuliaAI/MLJModelInterface.jl/pull/182?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaAI#diff-c3JjL3BhcmFtZXRlcl9pbnNwZWN0aW9uLmps) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ablaom commented 10 months ago

Thanks @pebeto for the review.