search

JuliaAI / MLJModelInterface.jl

Lightweight package to interface with MLJ
MIT License
37 stars 8 forks source link

Fix usage of MLJModelInterface #184

Closed davnn closed 8 months ago

davnn commented 8 months ago

The current usage of MLJModelInterface in the affected functions requires a global MLJModelInterface to be available, e.g. only importing @mlj_model would fail when MLJModelInterface is not available.

Using $MLJModelInterface fixes the problem by referring to the local MLJModelInterface.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9736531) 89.26% compared to head (33c6f60) 89.26%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #184 +/- ## ======================================= Coverage 89.26% 89.26% ======================================= Files 8 8 Lines 382 382 ======================================= Hits 341 341 Misses 41 41 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

davnn commented 8 months ago

@ablaom OutlierDetectionInterface.jl depends on @mlj_model, but cannot guarantee that MLJModelInterface is always available globally. Disregarding the problem for OutlierDetection.jl, this probably represents a bug for all users not importing the entire package.