search

JuliaAI / MLJModels.jl

Home of the MLJ model registry and tools for model queries and mode code loading
MIT License
80 stars 27 forks source link

Remove the section of code labelled "code to be removed in 0.15.0" #449

Closed DilumAluthge closed 2 years ago

DilumAluthge commented 2 years ago

@ablaom A couple questions:

  1. Is this PR correct? In other words, is it safe to remove these two methods?
  2. If so, could you briefly explain why it is safe to remove this code?
ablaom commented 2 years ago
  1. Yes.
  2. model used to be called wrapped_model. For some time you could still call wrapped_model and get/set the model (and get a dep warning). It's curious that this backwards-compatibility code was already partially removed, but not fully removed. But it can all go.