codecov-commenter
commented
2 years ago Codecov Report
Merging #463 (793c07a) into dev (831b117) will increase coverage by
1.41%. The diff coverage is8.79%.
@@ Coverage Diff @@
## dev #463 +/- ##
==========================================
+ Coverage 75.42% 76.84% +1.41%
==========================================
Files 12 16 +4
Lines 1050 1097 +47
==========================================
+ Hits 792 843 +51
+ Misses 258 254 -4 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/MLJModels.jl | 100.00% <ø> (ø) |
|
| src/registry/src/activate_registry_project.jl | 0.00% <0.00%> (ø) |
|
| src/registry/src/check_registry.jl | 0.00% <0.00%> (ø) |
|
| src/registry/src/update.jl | 0.00% <0.00%> (ø) |
|
| src/registry/test/info_dict.jl | 92.00% <ø> (ø) |
|
| src/loading.jl | 67.94% <25.00%> (+5.59%) |
:arrow_up: |
| src/init.jl | 100.00% <100.00%> (ø) |
|
| src/registry/src/Registry.jl | 100.00% <100.00%> (+100.00%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 831b117...793c07a. Read the comment docs.
This PR reorganizes the registry code by splitting off some of Registry.jl into separate files for inclusion, by putting the include calls in Registry.jl (instead of MLJModels.jl) and applying similar reshuffling to registry-specific test code.
This PR also refactors
check_registry()to make use of the new package MLJTestIntegration.jl, reducing code duplication. The return value ofcheck_registry()has changed from a vector to a table, but emptiness still means "success".Finally, the PR adds some private, experimental methods
registry_project()for returning lines of the registry project file, andactivate_registry_project([path,])for activating a clone of this registry.