search

JuliaAI / MLJModels.jl

Home of the MLJ model registry and tools for model queries and mode code loading
MIT License
79 stars 27 forks source link

For a 0.15.10 release #469

Closed ablaom closed 1 year ago

ablaom commented 1 year ago

462 #468 #463

To do:

codecov-commenter commented 1 year ago

Codecov Report

Merging #469 (adf82cb) into master (831b117) will increase coverage by 1.50%. The diff coverage is 14.60%.

@@            Coverage Diff             @@
##           master     #469      +/-   ##
==========================================
+ Coverage   75.42%   76.93%   +1.50%     
==========================================
  Files          12       16       +4     
  Lines        1050     1097      +47     
==========================================
+ Hits          792      844      +52     
+ Misses        258      253       -5
Impacted Files Coverage Δ
src/MLJModels.jl 100.00% <ø> (ø)
src/registry/src/activate_registry_project.jl 0.00% <0.00%> (ø)
src/registry/src/check_registry.jl 0.00% <0.00%> (ø)
src/registry/src/update.jl 0.00% <0.00%> (ø)
src/registry/test/info_dict.jl 92.00% <ø> (ø)
src/loading.jl 67.94% <77.77%> (+5.59%) :arrow_up:
src/builtins/Transformers.jl 96.24% <100.00%> (ø)
src/init.jl 100.00% <100.00%> (ø)
src/registry/src/Registry.jl 100.00% <100.00%> (+100.00%) :arrow_up:
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ablaom commented 1 year ago

Needs resolution of: https://github.com/JuliaAI/MLJScikitLearnInterface.jl/issues/42

ablaom commented 1 year ago

@OkonSamuel Can you please add your hack to .github/workflows/check_registry.yml to (hopefully) resolve the fail here?

OkonSamuel commented 1 year ago

@OkonSamuel Can you please add your hack to .github/workflows/check_registry.yml to (hopefully) resolve the fail here?

@ablaom I worked on it in https://github.com/JuliaAI/MLJModels.jl/pull/470, but the check_registry.yml still fails due to MissingImputator and GMMClusterer. On further investigation, I found out that MLJ registry load paths for GMMClusterer and MissingImputor are invalid. See https://github.com/JuliaAI/MLJModels.jl/blob/ldpath/src/registry/Metadata.toml#L269, https://github.com/JuliaAI/MLJModels.jl/blob/dev/src/registry/Metadata.toml#L301, https://github.com/sylvaticus/BetaML.jl/blob/v0.7.1/src/Imputation/Imputation_MLJ.jl#L251, https://github.com/sylvaticus/BetaML.jl/blob/v0.7.1/src/GMM/GMM_MLJ.jl#L149