search

JuliaAI / MLJModels.jl

Home of the MLJ model registry and tools for model queries and mode code loading
MIT License
78 stars 27 forks source link

Update registry with SymbolicRegression.jl #520

Closed MilesCranmer closed 11 months ago

MilesCranmer commented 12 months ago

Closes https://github.com/alan-turing-institute/MLJ.jl/issues/1032

(I wasn't sure if we were supposed to do it ourselves or not; feel free to close if needed. I just followed the instructions in MLJModels.@update.)

Since the SymbolicRegression.jl docstrings are technically invalid right now as they describe the @load API: https://astroautomata.com/SymbolicRegression.jl/dev/api/, let me know the timescale for the registry update and if I should update the docstrings with a temporary fix.

Thanks! Miles

MilesCranmer commented 11 months ago

@OkonSamuel @ablaom sorry to bother you, but I was wondering when this could be put up on the registry? I am just a bit worried about new users, because the SymbolicRegression.jl docstrings currently have the @load syntax, but this will not work until the registry is updated.

Thanks! Miles

OkonSamuel commented 11 months ago

@OkonSamuel @ablaom sorry to bother you, but I was wondering when this could be put up on the registry? I am just a bit worried about new users, because the SymbolicRegression.jl docstrings currently have the @load syntax, but this will not work until the registry is updated.

Thanks! Miles

I planned to close this today.

codecov-commenter commented 11 months ago

Codecov Report

Merging #520 (ba8fbe7) into dev (c72e67c) will decrease coverage by 0.16%. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##              dev     #520      +/-   ##
==========================================
- Coverage   76.92%   76.76%   -0.16%     
==========================================
  Files          16       16              
  Lines        1157     1162       +5     
==========================================
+ Hits          890      892       +2     
- Misses        267      270       +3

see 2 files with indirect coverage changes

OkonSamuel commented 11 months ago

closing in favor of #521

MilesCranmer commented 11 months ago

Thanks!

MilesCranmer commented 11 months ago

@OkonSamuel it seems as though @load SRRegressor is still unavailable. Maybe it requires a new release, i.e., MLJModels v0.16.9?

OkonSamuel commented 11 months ago

Yes. I'll go ahead and tag a new release.

MilesCranmer commented 11 months ago

Amazing, thanks so much for your quick turnarounds. It is much appreciated.