JuliaAI / MLJModels.jl

Home of the MLJ model registry and tools for model queries and mode code loading
MIT License
80 stars 27 forks source link

add sirus models to registry #524

Closed OkonSamuel closed 1 year ago

OkonSamuel commented 1 year ago

continuation of #519

codecov-commenter commented 1 year ago

Codecov Report

Merging #524 (abac36b) into dev (e7dda4a) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##              dev     #524   +/-   ##
=======================================
  Coverage   76.76%   76.76%           
=======================================
  Files          16       16           
  Lines        1162     1162           
=======================================
  Hits          892      892           
  Misses        270      270           
Files Changed Coverage Δ
src/MLJModels.jl 100.00% <ø> (ø)
rikhuijzer commented 1 year ago

@OkonSamuel why was a new PR by the way necessary?

OkonSamuel commented 1 year ago

@OkonSamuel why was a new PR by the way necessary?

We added a models from SymbolicRegression.jl after you made your initial PR. I decided to open a new PR to be safe.