JuliaAI / MLJModels.jl

Home of the MLJ model registry and tools for model queries and mode code loading
MIT License
78 stars 27 forks source link

Fix SIRUS `load_path`s #526

Closed rikhuijzer closed 9 months ago

rikhuijzer commented 9 months ago

I've made a mistake in https://github.com/JuliaAI/MLJModels.jl/pull/524, which causes the following (https://github.com/rikhuijzer/SIRUS.jl/issues/54):

julia> RulesClassifier = @load StableRulesClassifier pkg="SIRUS" verbosity=0
SIRUS.MLJImplementation.StableForestClassifier

Note that StableForestClassifier in the output should have been StableRulesClassifier.

This PR fixes these mistakes. Apologies for the noise.

codecov[bot] commented 9 months ago

Codecov Report

Patch coverage has no change and project coverage change: -0.09% :warning:

Comparison is base (ba5de1b) 76.76% compared to head (f3f9a0d) 76.67%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #526 +/- ## ========================================== - Coverage 76.76% 76.67% -0.09% ========================================== Files 16 16 Lines 1162 1162 ========================================== - Hits 892 891 -1 - Misses 270 271 +1 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/JuliaAI/MLJModels.jl/pull/526/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaAI)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rikhuijzer commented 9 months ago

The error on Julia 1.6 seems unrelated:

loading model code: Error During Test at /home/runner/work/MLJModels.jl/MLJModels.jl/test/runtests.jl:15
  Test threw exception
  Expression: include("loading.jl")
  LoadError: Unsatisfiable requirements detected for package Statistics [10745b16]:
   Statistics [10745b16] log:
   ├─possible versions are: 0.0.0 or uninstalled
   ├─restricted to versions * by MLJModels [d491faf4], leaving only versions 0.0.0
   │ └─MLJModels [d491faf4] log:
   │   ├─possible versions are: 0.16.10 or uninstalled
   │   └─MLJModels [d491faf4] is fixed to version 0.16.10
   ├─Statistics [10745b16] is fixed to version 0.0.0
   └─found to have no compatible versions left with MLJBase [a7f614a8]
     └─MLJBase [a7f614a8] log:
       ├─possible versions are: 0.1.0-0.21.14 or uninstalled
       ├─restricted to versions * by an explicit requirement, leaving only versions 0.1.0-0.21.14
       └─restricted by compatibility requirements with ScientificTypes [321657f4] to versions: [0.1.0-0.3.0, 0.15.0-0.18.11, 0.19.2-0.21.14] or uninstalled, leaving only versions: [0.1.0-0.3.0, 0.15.0-0.18.11, 0.19.2-0.21.14]
         └─ScientificTypes [321657f4] log:
           ├─possible versions are: 0.1.0-3.0.2 or uninstalled
           └─restricted to versions 3 by MLJModels [d491faf4], leaving only versions 3.0.0-3.0.2
             └─MLJModels [d491faf4] log: see above
ablaom commented 9 months ago

Okay, I'm now convinced the fail is orthogonal to this PR. A separate PR, #527, will address the fail.