Remove now redundant sckitlearn hack

JuliaAI / MLJModels.jl

Home of the MLJ model registry and tools for model queries and mode code loading

MIT License

80 stars 27 forks source link

Remove now redundant sckitlearn hack #529

Closed ablaom closed 8 months ago

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (2a678c4) 76.76% compared to head (4681818) 76.76%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #529 +/- ## ======================================= Coverage 76.76% 76.76% ======================================= Files 16 16 Lines 1162 1162 ======================================= Hits 892 892 Misses 270 270 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ablaom commented 1 year ago

Checked check_registry works by first inspecting draft PR directly onto master.

ablaom commented 12 months ago

@OkonSamuel Friendly reminder that a review would be nice.

OkonSamuel commented 8 months ago

I'm happy to drop it. But I'm trying to remember why we had it in the first place. EDIT: I remember now, For the linux builds we had an issue because the shared library used by Julia is different from that used by Conda. But since this PR runs it means that Julia dev team has updated the shared library used. Rather than deleting it out totally, I recommend just comment the lines of code that aren't needed. Should in case we face a similar issue in the future.