search

JuliaAI / MLJModels.jl

Home of the MLJ model registry and tools for model queries and mode code loading
MIT License
78 stars 27 forks source link

Fix input_scitype for InteractionTransformer #538

Closed ablaom closed 5 months ago

ablaom commented 5 months ago

The meaning of input_scitype for Static models is not clear in the MLJ spec, a fact this is corrected here. With this now clarified, the implementation for InteractionTransformer is not compliant and this PR fixes that.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4557e25) 76.76% compared to head (49e3f1a) 76.76%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #538 +/- ## ======================================= Coverage 76.76% 76.76% ======================================= Files 16 16 Lines 1162 1162 ======================================= Hits 892 892 Misses 270 270 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.