Closed tiemvanderdeure closed 2 months ago
Thanks for this. It seems that codecov is hanging. I've been having this issue elsewhere. Can you try updating the codecov GH action to version @v3
. You can do that here: https://github.com/JuliaAI/MLJModels.jl/blob/0de3aec7063f49a56d8f23252a42a4af896c599e/.github/workflows/ci.yml#L45
Don't use @v4
as that requires us to add a security token.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 77.08%. Comparing base (
5dc7eb2
) to head (1757802
). Report is 5 commits behind head on dev.:exclamation: Current head 1757802 differs from pull request most recent head 66303c4. Consider uploading reports for the commit 66303c4 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Could you please also fix this line:
More correct is eps(T)
, right?
More correct is
eps(T)
, right?
eps(T)
would fail if T
is an integer, but eps(std(v))
should always work.
Changes the float type of the fitresult of
Standardizer
toAbstractFloat
. This means standardizers will no longer force floats toFloat64
.I also removed the second definition of
fitresult_given_feature
- I think this must have been an oversight.