JuliaAI / MLJModels.jl

Home of the MLJ model registry and tools for model queries and mode code loading
MIT License
80 stars 27 forks source link

FeatureSelector is still exported #562

Closed adwasser closed 3 months ago

adwasser commented 3 months ago

It looks like the FeatureSelector transformation was moved to a different package in this PR:

https://github.com/JuliaAI/MLJModels.jl/pull/558

But the symbol is still exported

https://github.com/JuliaAI/MLJModels.jl/blob/320a29cbded365ada09183cbb5cba3dd00dd0721/src/MLJModels.jl#L46

which leads to a confusing user error:

UndefVarError: `FeatureSelector` not defined
ablaom commented 3 months ago

Good catch, thanks!