Closed OkonSamuel closed 3 years ago
Merging #61 (a9f76fb) into dev (08654c3) will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## dev #61 +/- ##
=======================================
Coverage 98.72% 98.73%
=======================================
Files 7 7
Lines 236 237 +1
=======================================
+ Hits 233 234 +1
Misses 3 3
Impacted Files | Coverage Δ | |
---|---|---|
src/convention/scitype.jl | 96.55% <100.00%> (ø) |
|
src/schema.jl | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 08654c3...a9f76fb. Read the comment docs.
Tables.getcolumns
andTables.columnnames
call underlying efficient methods. For example in the case ofDataFrame
table type,Tables.columnnames(X)
callspropertynames(X)
.Also the previous code leads to weird behaviour as shown below
So I recommend strictly adhering to the Tables.jl API.