search

JuliaAI / MLJScientificTypes.jl

Implementation of the MLJ scientific type convention
MIT License
17 stars 6 forks source link

Continuation of PR on improving errors for coerce #64

Closed ablaom closed 3 years ago

ablaom commented 3 years ago

Continuation of #62.

cc @OkonSamuel

Fixes one bit of logic: a "scientific type" is any subtype of Union{Missing,Nothing,Found} but one fallback for catching errors was missing the Nothing.

Otherwise, only tweaks doc-strings and the new error messages.

codecov-io commented 3 years ago

Codecov Report

Merging #64 (43cb6bc) into dev (3bd5193) will decrease coverage by 0.12%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #64      +/-   ##
==========================================
- Coverage   98.91%   98.79%   -0.13%     
==========================================
  Files           7        7              
  Lines         277      248      -29     
==========================================
- Hits          274      245      -29     
  Misses          3        3
Impacted Files Coverage Δ
src/coerce.jl 98.07% <100.00%> (+0.11%) :arrow_up:
src/convention/coerce.jl 98.70% <100.00%> (-0.25%) :arrow_down:
src/convention/scitype.jl 96.55% <0.00%> (-0.12%) :arrow_down:
src/init.jl 100.00% <0.00%> (ø)
src/schema.jl 100.00% <0.00%> (ø)
src/autotype.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3bd5193...43cb6bc. Read the comment docs.