JuliaAI / MLJScientificTypes.jl

Implementation of the MLJ scientific type convention
MIT License
17 stars 6 forks source link

Make `scitype` efficient for views of `CategoricalArray`s #78

Closed ablaom closed 3 years ago

ablaom commented 3 years ago

This code makes scitype avoid calling expensive type unions over elements in the case of CategoricalArray's. However, it does not catch views of CategoricalArrays. So the type in the method referenced needs to be broadened.

To include views of CategoricalArrays (which are not categorical arrays) is a bit awkward, but here's the latest authority on how to do this.