JuliaAI / MLJText.jl

A an MLJ extension for accessing models and tools related to text analysis
MIT License
11 stars 1 forks source link

CompatHelper: bump compat for ScientificTypesBase to 3, (keep existing compat) #15

Closed github-actions[bot] closed 2 years ago

github-actions[bot] commented 2 years ago

This pull request changes the compat entry for the ScientificTypesBase package from 2.2.0 to 2.2.0, 3. This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

codecov-commenter commented 2 years ago

Codecov Report

Merging #15 (5b18aa7) into dev (d772365) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev      #15   +/-   ##
=======================================
  Coverage   88.33%   88.33%           
=======================================
  Files           7        7           
  Lines         180      180           
=======================================
  Hits          159      159           
  Misses         21       21           
Impacted Files Coverage Δ
src/scitypes.jl 84.61% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d772365...5b18aa7. Read the comment docs.

ablaom commented 2 years ago

I suspect that, for testing purposes, this PR needs:

pazzo83 commented 2 years ago

Ok cool - should we just hold off until that is released?

ablaom commented 2 years ago

I don't understand this fail, which seems to be something new about testing under 1.7, as 1.3 tests pass.

In particular, I don't understand " ├─restricted to versions 2.2.2-2 by MLJText [5e27fcf9], leaving only versions 2.2.2-2.3.3" because this PR is extending the compat for ScientificTypesBase to include 3^.

Perhaps @DilumAluthge can explain?

Screen Shot 2021-12-24 at 7 01 22 AM

DilumAluthge commented 2 years ago

You'll need to update the compat entry for ScientificTypes to allow ScientificTypes v3.

DilumAluthge commented 2 years ago

Just FYI, the CI failure on 1.7 is a good thing. It tells us that the fix in https://github.com/JuliaRegistries/CompatHelper.jl/issues/298 is working correctly.

ablaom commented 2 years ago

@DilumAluthge Thanks for your help here!