Closed github-actions[bot] closed 2 years ago
Merging #15 (5b18aa7) into dev (d772365) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## dev #15 +/- ##
=======================================
Coverage 88.33% 88.33%
=======================================
Files 7 7
Lines 180 180
=======================================
Hits 159 159
Misses 21 21
Impacted Files | Coverage Δ | |
---|---|---|
src/scitypes.jl | 84.61% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d772365...5b18aa7. Read the comment docs.
I suspect that, for testing purposes, this PR needs:
Ok cool - should we just hold off until that is released?
I don't understand this fail, which seems to be something new about testing under 1.7, as 1.3 tests pass.
In particular, I don't understand " ├─restricted to versions 2.2.2-2 by MLJText [5e27fcf9], leaving only versions 2.2.2-2.3.3" because this PR is extending the compat for ScientificTypesBase to include 3^.
Perhaps @DilumAluthge can explain?
You'll need to update the compat entry for ScientificTypes to allow ScientificTypes v3.
Just FYI, the CI failure on 1.7 is a good thing. It tells us that the fix in https://github.com/JuliaRegistries/CompatHelper.jl/issues/298 is working correctly.
@DilumAluthge Thanks for your help here!
This pull request changes the compat entry for the
ScientificTypesBase
package from2.2.0
to2.2.0, 3
. This keeps the compat entries for earlier versions.Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.