search

JuliaAI / MLJText.jl

A an MLJ extension for accessing models and tools related to text analysis
MIT License
11 stars 1 forks source link

fix bug with BM 25 transformer - need to fit additional parameter #18

Closed pazzo83 closed 2 years ago

pazzo83 commented 2 years ago

Need to fit an additional parameter to properly transform documents.

codecov-commenter commented 2 years ago

Codecov Report

Merging #18 (01f0fe6) into dev (affd56b) will decrease coverage by 0.28%. The diff coverage is 92.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #18      +/-   ##
==========================================
- Coverage   88.33%   88.04%   -0.29%     
==========================================
  Files           7        7              
  Lines         180      184       +4     
==========================================
+ Hits          159      162       +3     
- Misses         21       22       +1
Impacted Files Coverage Δ
src/bagofwords_transformer.jl 88.00% <ø> (ø)
src/bm25_transformer.jl 87.80% <80.00%> (-1.39%) :arrow_down:
src/abstract_text_transformer.jl 75.86% <100.00%> (ø)
src/tfidf_transformer.jl 87.50% <100.00%> (ø)
src/utils.jl 97.67% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update affd56b...01f0fe6. Read the comment docs.

pazzo83 commented 2 years ago

Sounds good! I've also renamed the bag-of-words transformer to a more specific name: count transformer. Really bag of words transformers can be used to describe all three of the models here (they all are based on, essentially, bags of words)

pazzo83 commented 2 years ago

Sounds good thanks!!