search

JuliaAI / MLJText.jl

A an MLJ extension for accessing models and tools related to text analysis
MIT License
11 stars 1 forks source link

Tables 1.8.0 breaks scitypes for MLJText #25

Closed ablaom closed 1 year ago

ablaom commented 1 year ago

https://github.com/JuliaData/Tables.jl/issues/306


n_grams = [
    Dict("Hi" => 1, "name" => 1),
    Dict("name" => 1, "Sam" => 1),
]

using Tables

julia> Tables.istable(n_grams) # Tables 1.7.0
false

julia> Tables.istable(n_grams) # Tables 1.8.0
true

using TextAnalysis, ScientificTypes

julia> scitype(n_grams) # Tables 1.7.0
AbstractVector{Multiset{Textual}} (alias for AbstractArray{Multiset{Textual}, 1})

julia> scitype(n_grams) # Tables 1.8.0
Table{Union{AbstractVector{Count}, AbstractVector{Union{Missing, Count}}}}
ablaom commented 1 year ago

Above ScientificTypes PR should resolve this issue.