search

JuliaAI / MLJText.jl

A an MLJ extension for accessing models and tools related to text analysis
MIT License
11 stars 1 forks source link

Add local overloading of `scitype(...)` #8

Closed ablaom closed 2 years ago

ablaom commented 2 years ago

This PR adds the definitions of scitype previously at ScientificTypes 2.3.1, but absent in ScientificTypes 2.3.2.

ablaom commented 2 years ago

@pazzo83 Could you review please?

pazzo83 commented 2 years ago

This looks good to me! I like the differentiation between the plain n-gram and tagged-word n-gram!

ablaom commented 2 years ago

Thanks!

I like the differentiation between the plain n-gram and tagged-word n-gram!

Yes, but to be clear, these are just local aliases, ie they are not exported.