search

JuliaAI / MLJTuning.jl

Hyperparameter optimization algorithms for use in the MLJ machine learning framework
MIT License
66 stars 12 forks source link

Allow Tuples of ranges #198

Open ParadaCarleton opened 9 months ago

ParadaCarleton commented 9 months ago

Declaring ranges in vectors creates type instabilities (which show up as false positives on JET.jl), besides feeling a bit weird and encouraging bad habits (using vectors for a small collection of heterogenous types). I assume it doesn't have much of an effect on performance here (or else it wouldn't be used), but would it make sense to at least allow users to pass tuples instead of vectors?

ablaom commented 9 months ago

Thanks for this investigation.

I find it hard to imagine a use-case where the performance improvement of tuples is worth a breaking change. No objection to allowing tuples. PR welcome.