search

JuliaAI / MLJTuning.jl

Hyperparameter optimization algorithms for use in the MLJ machine learning framework
MIT License
66 stars 12 forks source link

Add prediction type check for Explicit strategy #201

Closed ablaom closed 6 months ago

ablaom commented 6 months ago

Closes #200

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e3293dc) 86.44% compared to head (961faee) 87.17%. Report is 3 commits behind head on dev.

:exclamation: Current head 961faee differs from pull request most recent head 53700b3. Consider uploading reports for the commit 53700b3 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #201 +/- ## ========================================== + Coverage 86.44% 87.17% +0.73% ========================================== Files 13 13 Lines 649 655 +6 ========================================== + Hits 561 571 +10 + Misses 88 84 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ablaom commented 6 months ago

(That's possible)

Good point, I hadn't thought of that. As it turns out it's not possible, but only because of bug. So I'm waiting on:

and then I'll update this PR.