JuliaAI / MLJXGBoostInterface.jl

MIT License
11 stars 6 forks source link

The tree method `gpu_hist` is deprecated since 2.0.0 #54

Open Moelf opened 2 weeks ago

Moelf commented 2 weeks ago
The tree method `gpu_hist` is deprecated since 2.0.0. To use GPU training, set the `device` parameter to CUDA instead.

but currently this package doesn't support device="gpu"

ablaom commented 2 weeks ago

Mmm. The pattern elsewhere in MLJ is to have an acceleration hyperparameter, which takes an instance of AbstractResource, provided by ComputationalResources.jl. Examples are CPU1() ("cpu") and CUDALibs() ("gpu"). On the other hand, we generally try to mirror the original names, so should still provide device. We could provided both, but then there's a little logic needed to deal with any ambiguity/conflict.

Moelf commented 1 week ago

I can try a PR but because there's no CI for this I'm a bit hesitant to blindly try it