Closed jbrea closed 2 years ago
Merging #18 (ccaee38) into dev (f2daf08) will decrease coverage by
2.06%
. The diff coverage is34.37%
.
@@ Coverage Diff @@
## dev #18 +/- ##
==========================================
- Coverage 34.53% 32.46% -2.07%
==========================================
Files 1 1
Lines 139 77 -62
==========================================
- Hits 48 25 -23
+ Misses 91 52 -39
Impacted Files | Coverage Δ | |
---|---|---|
src/data.jl | 32.46% <34.37%> (-2.07%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Many thanks @jbrea !
@darenasc or @OkonSamuel Going on leave for a week. Any chance one of you could review this?
Hopefully I can then jump and tag a new (breaking release) with the new HTTP compat.
Does anyone have the time to look at this within the next few days? I would like to use the updated version for the course that starts mid September.
Breaking is only the removal of the keyword argument api_keys
. However, this keyword argument never did anything, so I don't expect to break user code.
Thanks, @ablaom!
This addresses #16 and #17.
In addition,
maxbytes
to theload
function to support loading of the first few rows of datasets.api_keys
, which didn't have any effect so far unless making some functions throw errors (this is technically breaking).