JuliaAI / ScientificTypes.jl

An API for dispatching on the "scientific" type of data instead of the machine type
MIT License
96 stars 8 forks source link

The scitype of `[missing, missing]` should be Missing #106

Closed DilumAluthge closed 4 years ago

DilumAluthge commented 4 years ago

Fixes #105

With this patch:

julia> import ScientificTypes

julia> import MLJScientificTypes

julia> ScientificTypes.set_convention(MLJScientificTypes.MLJ())

julia> ScientificTypes.scitype([1, 2])
AbstractVector{ScientificTypes.Count} = AbstractArray{ScientificTypes.Count,1}

julia> ScientificTypes.scitype([1.0, 2.0])
AbstractVector{ScientificTypes.Continuous} = AbstractArray{ScientificTypes.Continuous,1}

julia> ScientificTypes.scitype(["foo", "bar"])
AbstractVector{ScientificTypes.Textual} = AbstractArray{ScientificTypes.Textual,1}

julia> ScientificTypes.scitype([1, missing])
AbstractVector{Union{Missing, ScientificTypes.Count}} = AbstractArray{Union{Missing, ScientificTypes.Count},1}

julia> ScientificTypes.scitype([1.0, missing])
AbstractVector{Union{Missing, ScientificTypes.Continuous}} = AbstractArray{Union{Missing, ScientificTypes.Continuous},1}

julia> ScientificTypes.scitype(["foo", missing])
AbstractVector{Union{Missing, ScientificTypes.Textual}} = AbstractArray{Union{Missing, ScientificTypes.Textual},1}

julia> ScientificTypes.scitype([missing, missing])
AbstractVector{Missing} = AbstractArray{Missing,1}

julia> ScientificTypes.scitype(Missing[])
AbstractVector{Missing} = AbstractArray{Missing,1}

cc: @ablaom

codecov-commenter commented 4 years ago

Codecov Report

Merging #106 into master will increase coverage by 0.09%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
+ Coverage   96.87%   96.96%   +0.09%     
==========================================
  Files           2        2              
  Lines          32       33       +1     
==========================================
+ Hits           31       32       +1     
  Misses          1        1              
Impacted Files Coverage Δ
src/scitype.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b63d436...5e26994. Read the comment docs.

tlienart commented 4 years ago

Thanks that makes sense