search

JuliaAI / ScientificTypes.jl

An API for dispatching on the "scientific" type of data instead of the machine type
MIT License
96 stars 8 forks source link

Query on :discrete_to_continuous autotypes option #16

Closed ablaom closed 4 years ago

ablaom commented 5 years ago

From the doc string:

Note that it doesn't touch features already marked as `Finite`.

But Finite is not tested in the code:

function discrete_to_continuous(type::Type, _, _)
    nonmissing(type) <: Union{Count,Integer} && return T_or_Union_Missing_T(type, Continuous)
    return type
end

Under the convention mlj this won't matter, but under any other convention it might, no?

tlienart commented 5 years ago

Yes nice, I'll fix the doc to clarify what it does exactly.