search

JuliaAI / ScientificTypes.jl

An API for dispatching on the "scientific" type of data instead of the machine type
MIT License
96 stars 8 forks source link

Accept strings in `coerce` #161

Closed juliohm closed 2 years ago

juliohm commented 2 years ago

Currently coerce(table, "col name" => Continuous) fails. I had to wrap the column name as Symbol("col name") for it to work.

ablaom commented 2 years ago

Thanks. Just to clarify, you are requesting this as a feature, not reporting what you think may be a bug?

juliohm commented 2 years ago

As a feature :)

On Thu, Sep 23, 2021, 17:30 Anthony Blaom, PhD @.***> wrote:

Thanks. Just to clarify, you are requesting this a feature, not reporting what you think may be a bug?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JuliaAI/ScientificTypes.jl/issues/161#issuecomment-926131177, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZQW3LLWGBPRDJSX54QISDUDOE5FANCNFSM5ETZYXUQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

ablaom commented 2 years ago

Sounds reasonable to me. PR welcome :-)