search

JuliaAI / ScientificTypes.jl

An API for dispatching on the "scientific" type of data instead of the machine type
MIT License
96 stars 8 forks source link

Move text analysis scitype out #169

Closed ablaom closed 2 years ago

ablaom commented 2 years ago

This PR removes the text analysis scitype overloadings and dumps CorpusLoaders as a dependency.

This functionality was marked as experimental and does not trigger a breaking release.

However, as a precaution:

ablaom commented 2 years ago

cc @pazzo83

codecov-commenter commented 2 years ago

Codecov Report

Merging #169 (11f06ba) into dev (4c4ed62) will increase coverage by 4.02%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #169      +/-   ##
==========================================
+ Coverage   90.49%   94.52%   +4.02%     
==========================================
  Files           7        7              
  Lines         305      292      -13     
==========================================
  Hits          276      276              
+ Misses         29       16      -13
Impacted Files Coverage Δ
src/convention/scitype.jl 78.37% <ø> (+20.37%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4c4ed62...11f06ba. Read the comment docs.