This PR removes the overloading for scitype for persistence diagrams.
@mtsch Implementations of scitype() for more exotic types should now appear in packages defining the relevant types, to avoid onerous dependencies in ScientificTypes. (Exotic scitypes themselves can remain in ScientificTypesBase). I'm pretty sure the only package likely be broken by this removal is PersistenceDiagrams.jl, which I have tested locally as unaffected. In any case, I am happy to make a PR there to implement scitype for persistence diagrams (ie, add the code removed by the current PR, which I have only commented out).
This PR removes the overloading for
scitypefor persistence diagrams.@mtsch Implementations of
scitype()for more exotic types should now appear in packages defining the relevant types, to avoid onerous dependencies in ScientificTypes. (Exotic scitypes themselves can remain in ScientificTypesBase). I'm pretty sure the only package likely be broken by this removal is PersistenceDiagrams.jl, which I have tested locally as unaffected. In any case, I am happy to make a PR there to implementscitypefor persistence diagrams (ie, add the code removed by the current PR, which I have only commented out).